Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading "Cannot mix synchronous and asynchronous operation on process stream." logs. #4711

Merged
merged 3 commits into from Feb 13, 2024

Conversation

hxdhttk
Copy link
Contributor

@hxdhttk hxdhttk commented Feb 12, 2024

By searching via Google with the following keywords: cannot mix synchronous and asynchronous operation on process stream. site:github.com, there are many results in the repo that showing misleading logs to the users and maintainers, since the log is originated from the proc.StandardError.ReadToEnd() calls not from the core the user wished to start.

According to the doc, it is not able to start both synchronous and asynchronous redirections on the same process stream object. v2rayN starts the asynchronous redirection of stderr and stdout, and when the core fails to start, v2rayN starts the synchronous redirection of stderr, which triggers the exception in the PR title.

@2dust 2dust merged commit c03c981 into 2dust:master Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants