Should Table::SelectRectangle() wrap in the way it does?

[lukester1975]

Hi

As subject - it leads to surprising (to me!) behaviour:

#include <ftxui/dom/table.hpp>
#include <ftxui/screen/screen.hpp>

#include <iostream>

void bad()
{
	auto table = ftxui::Table({ { "h1" }, { "h2" } });
	table.SelectAll().Decorate(ftxui::flex_grow);
	table.SelectRows(2, -1).DecorateAlternateRow(ftxui::bgcolor(ftxui::Color::Palette256::Grey30));

	auto document = table.Render();
	auto screen = ftxui::Screen::Create(ftxui::Dimension::Full(), ftxui::Dimension::Fit(document));

	ftxui::Render(screen, document);
	screen.Print();
}

void ok()
{
	auto table = ftxui::Table({ { "h1" }, { "h2" }, { "r1" }, { "r2" }, { "r3" } });
	table.SelectAll().Decorate(ftxui::flex_grow);
	table.SelectRows(2, -1).DecorateAlternateRow(ftxui::bgcolor(ftxui::Color::Palette256::Grey30));

	auto document = table.Render();
	auto screen = ftxui::Screen::Create(ftxui::Dimension::Full(), ftxui::Dimension::Fit(document));

	ftxui::Render(screen, document);
	screen.Print();
}

I.e. two header rows, then alternate background colours on data rows. In the first case, decorating row 2 -> end wraps back to 0, which I assume is unintentional?

It seems a shame to have to check that there are data rows before calling DecorateAlternateRow() so I did a quick hack fix here: lukester1975@0a19eba.

Thanks!

[ArthurSonzogni]

Yes, we should probably fix this.
Thanks for reporting it!