Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New assembly: option to add feature with assembly scars #193

Open
manulera opened this issue Jan 29, 2024 · 3 comments
Open

New assembly: option to add feature with assembly scars #193

manulera opened this issue Jan 29, 2024 · 3 comments

Comments

@manulera
Copy link
Collaborator

In the new assembly implementation, it would be good to have a boolean option to select whether features are added to indicate where joins between fragments happened.

@BjornFJohansson
Copy link
Owner

Yes! I have though of a different solution to this, but never got around to it.
The features is a list property of the seq object. Perhaps, the scar features could be saved in another list that could be appended or not to the feature list. That way they are there, but only visible if the user wants them.

@manulera
Copy link
Collaborator Author

manulera commented Mar 4, 2024

I personally think deciding in advance (default=False) whether to include them or not in the normal seqfeature list would be simpler downstream than adding a separate property to the Dseqrecord class.

A separate property would require handling when exporting to gb files and when doing further manipulations to the sequence (e.g. a cut).

What do you think?

@BjornFJohansson
Copy link
Owner

Sounds good as well. Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants