Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add predefined queues support #14

Open
eugeneyalansky opened this issue Jan 29, 2021 · 1 comment
Open

Add predefined queues support #14

eugeneyalansky opened this issue Jan 29, 2021 · 1 comment

Comments

@eugeneyalansky
Copy link

Motivation:

In some environments creating new queues might be restricted, even though queue exists.

Issue:

The current implementation will declare a queue if it does not yet exist in Broker.queues and since Broker.queues initialized empty Broker.decalre_queue will always try to create the sqs queue.

I'd like to add support for already defined queues.
By allowing to pass the queues attribute to the broker initialization can solve predefined queues issue.

If a new task with a new queue will be presented to the broker - the broker will still try to create a queue and it should give the desired result (Created queue in case of CreateQueue policy is granted, or Error that will describe the lack of permissions to do so)

@Bogdanp
Copy link
Owner

Bogdanp commented Jan 29, 2021

Sounds like a good idea to me. Feel free to open a PR and I'll take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants