Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXME: TBD in audiosocket.go #1

Open
juansalvatella opened this issue Feb 11, 2019 · 1 comment
Open

FIXME: TBD in audiosocket.go #1

juansalvatella opened this issue Feb 11, 2019 · 1 comment

Comments

@juansalvatella
Copy link

Hi Sean,

In audiosocket.go there is a FIXME comment explaining that the Asterisk side of error reporting is missing if I am not mistaken. Could you please share any thoughts on how this should be implemented and I may be able to make a pull request with the changes.

Thanks!

@Ulexus
Copy link
Member

Ulexus commented Feb 12, 2019

Basically, the app_audiosocket.c treats everything which is not type 0x10 (after the initial packet) as a stop indication.

The relevant code is here and here. Ideally, it should handle each defined type and log the error or otherwise handle it appropriately. This wasn't important for my initial use, but it should be done for completeness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants