Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong minicap invocation inside the 'util' unit #701

Open
ghost opened this issue Aug 30, 2023 · 0 comments
Open

Wrong minicap invocation inside the 'util' unit #701

ghost opened this issue Aug 30, 2023 · 0 comments

Comments

@ghost
Copy link

ghost commented Aug 30, 2023

https://github.com/DeviceFarmer/stf/blob/3d3af0e9acf91d8beca500390e88d4ebd518f4ef/lib/units/device/plugins/util/display.js#L31C23-L31C23

This doesn't happen in most cases since this is only triggered if a certain exception happen in the 'readInfo' function, although when triggered infoFromMinicap calls minicap.run with a single command parameter, although the run method expects 2 arguments, more specifically, the minicap mode, either 'minicap-apk' or 'minicap-bin'.

I'm not sure how to reproduce this, but a simple look at the code will be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants