Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions Bump #184

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

Versions Bump #184

wants to merge 52 commits into from

Conversation

galek
Copy link

@galek galek commented Mar 1, 2021

Updated versions of database to latest. And Ubuntu from 16 to 21

Copy link
Member

@koral-- koral-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR does not pass CI build.
Also sign off is missing

@@ -15,57 +15,57 @@ EXPOSE 3000
# installs development files for node-gyp so that npm install won't have to
# wait for them on the first native module installation.
RUN export DEBIAN_FRONTEND=noninteractive && \
useradd --system \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why formatting here is changed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the auto-formatting

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR does not pass CI build.
Can you provide more information, or main error it's missing signing?

also sign off is missing
Okay, 5 mins

@@ -3,7 +3,7 @@ version: "3"
services:
rethinkdb:
container_name: rethinkdb
image: rethinkdb:2.3
image: rethinkdb:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use fixed version.
It is ok to update to 2.4.1 but not to latest.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@galek
Copy link
Author

galek commented Mar 1, 2021

@koral-- can you reply, why in docker file you don't use nvm and latest nodejs version?

@koral--
Copy link
Member

koral-- commented Mar 1, 2021

STF won't build with latest node version.

@galek
Copy link
Author

galek commented Mar 1, 2021

STF won't build with latest node version.

okay, I will try to fix it

Updated to latest version of RDB. With old version project is not started

Removed yarn.lock

Version dump

Version dump
@galek
Copy link
Author

galek commented Mar 21, 2021

@koral, can you describe the actual codebase status?
(How I can see - you is used angularJS for frontend and express for backend - it's correct?).
Authentication does not work?

I would suggest separate frontend from backend and rewrite it to nestsjs and modern angular
The current codebase is fine working with nodejs 9.9

@koral--
Copy link
Member

koral-- commented Mar 21, 2021

I'm not a JS expert but will try to answer.

How I can see - you is used angularJS for frontend and express for backend - it's correct?

Correct.

Authentication does not work?

Which method?

I would suggest separate frontend from backend and rewrite it to nestsjs and modern angular

LGTM at a glance. Upgrading Angular is perfectly reasonable.
Regarding NestJS, maybe @nanoscopic have some opinion?

@galek
Copy link
Author

galek commented Mar 21, 2021

Which method?

I don't know how to change authentication method, but I always get auth_mock in URL

Regarding NestJS, maybe @nanoscopic have some opinion?

NestJS has express/fastify framework in the core, it's just a wrapper that will provide typization. And this framework has is angular-like code style.

And I saw repos stf_ios_support and stf-ios-provider, can you describe what is it? I don't fully understand the structure of the project

@koral--
Copy link
Member

koral-- commented Mar 22, 2021

Regarding auth there are a few methods available: look at https://github.com/DeviceFarmer/stf/blob/master/doc/DEPLOYMENT.md#stf-authservice

Regarding NestJS fine for me, if you will be able to rewrite using it, PRs are welcome.

Regarding iOS-related repos this is an unfinished @nanoscopic's work about iOS support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants