Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Bower dependencies to npm #510

Open
wants to merge 81 commits into
base: master
Choose a base branch
from

Conversation

DaniilSmirnov
Copy link

  • Moved all bower dependencies to npm
  • added running tests from package.json

@koral--
Copy link
Member

koral-- commented Apr 18, 2022

Please add a sign-off, so DCO check will pass.

di.smirnov added 2 commits April 18, 2022 22:52
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
@DaniilSmirnov
Copy link
Author

Sign-off added, checks passed :)

lib/cli/please.js Outdated Show resolved Hide resolved
@koral--
Copy link
Member

koral-- commented Apr 19, 2022

@denis99999 @pcrepieux WDYT?

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Copy link

@denis99999 denis99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here are additional comments to the review:

  • Why did you bring this PR, what is your motivation? Because even if bower is not recommended for a new front-end project, it works well and it is maintained, it is rather AngularJS which is no longer maintained and can be a problem for the evolution of the front-end .

  • You should regenerate properly the yarn.lock file and commit it also, like this:

// first clean your repo (node_modules, etc.)
$ rm yarn.lock
$ npm install -g yarn
$ yarn install

  • In local mode after the authentication step, the following warning appears in the web console, please fix it:
    load-angularJS-more-than-twice

  • while running yarn install, the following warning appears, please fix it:

debian@debian:~/GITHUB/stf$ . ../stf-build.sh 17.9.0
Now using node v17.9.0 (npm v8.5.5)
yarn install v1.22.18
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
[4/5] Linking dependencies...
warning "ng-file-upload > grunt-contrib-concat@0.5.1" has unmet peer dependency "grunt@>=0.4.0".
[5/5] Building fresh packages...
success Saved lockfile.
$ not-in-install && gulp build || in-install
Done in 43.48s.
  • while APK download using UI with an error message in a window the close button is no more present, I think this is due to your upgrade to AngularJS 1.5.11 from 1.5.0-rc2, here are the old behavior and the new one, please fix it:
    app-upload-with-error
    app-upload-with-error-without-closing

lib/cli/please.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
webpack.config.js Outdated Show resolved Hide resolved
@denis99999
Copy link

@denis99999 @pcrepieux WDYT?

Look at my review on this item! This line must not be removed and the errors generated must be solved!

@DaniilSmirnov
Copy link
Author

  • Why did you bring this PR, what is your motivation? Because even if bower is not recommended for a new front-end project, it works well and it is maintained, it is rather AngularJS which is no longer maintained and can be a problem for the evolution of the front-end .

I plan in the future (this or the next quarter of the year) to make a PR in which the angular will be replaced with something more modern, maybe React

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
di.smirnov added 3 commits April 19, 2022 21:48
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
@DaniilSmirnov
Copy link
Author

DaniilSmirnov commented Apr 20, 2022

Fixed in last commit
image

it happened after bootstrap update

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Copy link

@denis99999 denis99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • trying to yarn install I got this error:
debian@debian:~/GITHUB/stf$ . ../stf-build.sh 17
Now using node v17.9.0 (npm v8.5.5)
yarn install v1.22.18
error An unexpected error occurred: "Unknown token: { line: 1458, col: 1, type: 'INVALID', value: undefined } 1458:1 in /home/debian/GITHUB/stf/yarn.lock".
info If you think this is a bug, please open a bug report with the information provided in "/home/debian/GITHUB/stf/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

I removed yarn.lock file and regenerated it properly by running the yarn install command, do that please and do not update manuallly this file because that is forbidden and lead to inconsistencies

  • After that yarn install and gulp test worked well, but trying to run STF locally I got the following exception, please fix it:
debian@debian:~/GITHUB/stf$ ./bin/stf local --public-ip 192.168.1.102
2022-04-21T09:41:41.376Z INF/util:procutil 9538 [*] Forking "/home/debian/GITHUB/stf/lib/cli migrate"
node:internal/validators:120
    throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at new NodeError (node:internal/errors:372:5)
    at validateString (node:internal/validators:120:11)
    at Object.parse (node:path:1450:5)
    at verify (/home/debian/GITHUB/stf/node_modules/please-update-dependencies/index.js:14:18)
    at module.exports (/home/debian/GITHUB/stf/node_modules/please-update-dependencies/index.js:131:8)
    at Object.<anonymous> (/home/debian/GITHUB/stf/lib/cli/please.js:2:38)
    at Module._compile (node:internal/modules/cjs/loader:1099:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/debian/GITHUB/stf/bin/stf:2:1)
    at Module._compile (node:internal/modules/cjs/loader:1099:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:975:32) {
  code: 'ERR_INVALID_ARG_TYPE'
}
  • Before posting a commit on your PR, please fully test your updates, it is a prerequisite for a review whose main purpose is not to debug a PR, thanks

Comment on lines +39 to +43
, alias: {
localforage: 'localforage/dist/localforage.js'
, 'socket.io': 'socket.io-client'
, stats: 'stats.js/src/Stats.js'
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the risk of repeating myself, add 2 spaces to align the alias section

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make the change please

@denis99999
Copy link

I plan in the future (this or the next quarter of the year) to make a PR in which the angular will be replaced with something more modern, maybe React

What feature(s) do you plan to add to STF ?

@denis99999
Copy link

@DaniilSmirnov, look at PR #522 and PR DeviceFarmer/please-update-dependencies#1, they fix the remaining issue, when they will be merged, you will be able to restore the lib/cli/please.js file at his original state

Energoblock and others added 30 commits October 31, 2022 17:09
…tps (DeviceFarmer#607)

Signed-off-by: Energoblock <7158577+Energoblock@users.noreply.github.com>

Signed-off-by: Energoblock <7158577+Energoblock@users.noreply.github.com>
* Enable device market name

Signed-off-by: mivashkin <mivashkin@playtika.com>

Co-authored-by: mivashkin <mivashkin@playtika.com>
Co-authored-by: Karol Wrótniak <karol.wrotniak@droidsonroids.pl>
Signed-off-by: Riste <rsamardjiev@playtika.com>
Bumps [moment](https://github.com/moment/moment) from 2.29.3 to 2.29.4.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](moment/moment@2.29.3...2.29.4)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases)
- [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2)

---
updated-dependencies:
- dependency-name: decode-uri-component
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Update Adbkit to 3.2.3

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>
# Conflicts:
#	lib/units/device/resources/service.js
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants