Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini Question #96

Open
vanja-san opened this issue Jun 19, 2023 · 17 comments
Open

Mini Question #96

vanja-san opened this issue Jun 19, 2023 · 17 comments

Comments

@vanja-san
Copy link
Contributor

Is that possible? Only I haven't figured out what to do with a multi-line message.
Maybe something will interest you, but it's not certain.

Screenshots

изображение
изображение

@Gibbu
Copy link
Member

Gibbu commented Jun 20, 2023

I really really like that chatbox design. Was never really happy with the current one.
I might actually yoink that and add it in a optional import or even straight to the theme.

Did you make these designs or yoinked them yourself?

@Gibbu
Copy link
Member

Gibbu commented Jun 20, 2023

Getting pretty close
image

@vanja-san
Copy link
Contributor Author

vanja-san commented Jun 20, 2023

@Gibbu Did it myself in Figma. An idea came up and I decided to sketch it out.
So if you're interested in something, feel free to take it. 😌👍
How will the chatbox function with multi-line messages, have you thought this through?

And I think this arrangement is more interesting:
изображение

@Gibbu
Copy link
Member

Gibbu commented Jun 20, 2023

Multiline messages are handled. I did have an effect in mind where the bottom bar would overlap both the channels and messages. So you were able to see the channels and messages behind it inbetween the bottom gaps.

But if the textbox had more than 1 line it'd cover the chat messages.
image

And I'm still tinkering around with the layout of things.

@vanja-san
Copy link
Contributor Author

@Gibbu By the way, how will this panel look on the Friends page? Where is the list of friends.
How many problematic points. It takes a lot of thinking. 🥲

@Gibbu
Copy link
Member

Gibbu commented Jun 20, 2023

It's a little weird, but I've got 2 ideas. The first didn't really look nice.

  1. Make the user area "float" so it's not attached to the main content area.

    But that made it move weirdly and didn't look nice.

  2. Move the search bar down and make a psuedo bar for it to be placed on.

    Probably the best option. But that'll not fix it for other pages such as the Nitro pages (which I don't care about)

This is what I've currently got:

image

@vanja-san
Copy link
Contributor Author

vanja-san commented Jun 20, 2023

@Gibbu Is it possible to change the style only for a certain page?
Take the Stylus for Browser extension as an example, where you can make styles separately for each link.

If you can change just the Friends page, you can do this:
изображение

@Gibbu
Copy link
Member

Gibbu commented Jun 20, 2023

That's what I said in the 1st point. It didn't really work well.
The container would move around the place and look weird.

@vanja-san
Copy link
Contributor Author

vanja-san commented Jun 20, 2023

@Gibbu that if (search friends):
изображение

@Gibbu
Copy link
Member

Gibbu commented Jun 20, 2023

Yeah, that's probably the best solution and looks quite nice imo

@vanja-san
Copy link
Contributor Author

vanja-san commented Jun 20, 2023

@Gibbu will it be possible to implement the change of the right side (from the message to the search and back)?
I mean, won't there be any problems with it?

What if we make the chatbox static without resizing even in multi-line messages?
Well, that is the last resort.

@Gibbu
Copy link
Member

Gibbu commented Jun 20, 2023

It should be fine since the chatbox is not rendered while not in a page that isn't a chatbox.

@Gibbu
Copy link
Member

Gibbu commented Jun 20, 2023

I've pushed what changes I've go so far to the theme

@vanja-san
Copy link
Contributor Author

vanja-san commented Jun 20, 2023

@Gibbu What does the final result look like? Does it take time to update?
I just have version 1.0.10 all the time.
изображение

@Gibbu
Copy link
Member

Gibbu commented Jun 20, 2023

The base file doesn't change. Just re-enable your theme for it to auto download the base css

@vanja-san
Copy link
Contributor Author

vanja-san commented Jun 20, 2023

@Gibbu If the list of friends is empty (Online, All and etc.), it displays as follows:
изображение
maybe move the top tabs (Online, All, Banned, etc.) there instead of searching.

изображение

Then it won't disappear either. Style tabs

изображение

@xsm2
Copy link

xsm2 commented Jun 20, 2023

There are 2 bugs when playing games, the first one is that the activity (playing game) appears under the profile, the second one is a bug with discord game invitations

imagen

imagen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants