Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go Tests #9

Open
amitai-devops opened this issue Dec 19, 2022 · 2 comments
Open

Add Go Tests #9

amitai-devops opened this issue Dec 19, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@amitai-devops
Copy link
Collaborator

No description provided.

@amitai-devops amitai-devops added enhancement New feature or request help wanted Extra attention is needed labels Dec 19, 2022
@ElementTech ElementTech added the good first issue Good for newcomers label Dec 19, 2022
@tanryberdi
Copy link

@amitai-devops @jatalocks could you please give more details about this issue? I could not find PodReconciler for adding tests

@amitai-devops
Copy link
Collaborator Author

amitai-devops commented Dec 20, 2022

Hey @tanryberdi, thank you first very much for your contribution! I am not too advanced in Go and haven't learned yet how to write Tests but I know its needed. This project doesn't have a lot of files but I've split them between 3 main ones:

Structs and Types: pod_controller_types.go. This file contains the "PodReconciler" struct type.

Functions: pod_controller_functions.go

Main Function (Reconciliation Loop), the one main.go enters: pod_controller.go. This file contains the "PodReconciler" function.

All that is needed to is write a pod_controller_tests.go I assume and make sure it checks the core function of this controller.

@amitai-devops amitai-devops changed the title Add Go Tests for PodReconciler Add Go Tests Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants