Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment modal is closed after editing or creation #3922

Closed
4 tasks
rolodato opened this issue May 10, 2024 · 1 comment · Fixed by #4109
Closed
4 tasks

Segment modal is closed after editing or creation #3922

rolodato opened this issue May 10, 2024 · 1 comment · Fixed by #4109
Assignees
Labels
bug Something isn't working

Comments

@rolodato
Copy link
Contributor

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

When creating or editing a segment, the modal is closed immediately after changes are saved, with no confirmation or possibility to continue making further changes. I'm almost certain this did not use to be the case, and is inconsistent with the behaviour for features (the modal stays open as expected)

Steps To Reproduce

  1. Create or edit any segment
  2. Save changes

The modal is closed with no confirmation that changes were saved, or possibility to continue making changes.

Expected behavior

The modal should stay open and should show confirmation when changes are saved, similar to how Features behave:

save-feature.mov

Screenshots

No response

@rolodato rolodato added the bug Something isn't working label May 10, 2024
@kyle-ssg
Copy link
Member

kyle-ssg commented Jun 4, 2024

It didn't used to be the case because our UX audit suggested we close the modal.

I'll adjust it to keep it open.

@kyle-ssg kyle-ssg self-assigned this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants