Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: feature state value conversion #3946

Merged
merged 9 commits into from
Jun 13, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

When determining a feature state's feature_state_value the frontend was trying to base it on the value. Instead, the frontend should base it on the type since the BE does not clear old values when the types change.

How did you test this code?

Please describe.

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 4:18pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 4:18pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 4:18pm

Copy link
Contributor

github-actions bot commented May 14, 2024

Uffizzi Preview deployment-51709 was deleted.

@kyle-ssg kyle-ssg added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit d4f948d Jun 13, 2024
21 checks passed
@kyle-ssg kyle-ssg deleted the chore/improve-feature-state-value-conversion branch June 13, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change request diff shows incorrect value diff
2 participants