Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(versioning): webhooks not triggered when new version published #3953

merged 1 commit into from
May 22, 2024


Copy link

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request


Fixes an issue calling the call_environment_webhooks function with the environment object instead of its id attribute.

How did you test this code?

Update existing unit test.

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 9:44am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 9:44am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 9:44am

Copy link

github-actions bot commented May 15, 2024

Uffizzi Preview deployment-51749 was deleted.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.00%. Comparing base (06eb8a4) to head (face933).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3953   +/-   ##
  Coverage   96.00%   96.00%           
  Files        1135     1135           
  Lines       36380    36380           
  Hits        34928    34928           
  Misses       1452     1452           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell requested review from a team and khvn26 and removed request for a team May 15, 2024 11:06
@matthewelwell matthewelwell added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit fb2191b May 22, 2024
24 checks passed
@matthewelwell matthewelwell deleted the fix/versioning-webhooks branch May 22, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
api Issue related to the REST API
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants