Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set api usage billing to 100k #3996

Merged
merged 11 commits into from
May 28, 2024
Merged

Conversation

zachaysan
Copy link
Contributor

@zachaysan zachaysan commented May 21, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  1. Set up billing to 100k from 1000 from the Chargebee add-on code.
  2. Fix a horrible bug that would have allowed customers to be billed multiple times for the same API calls.

How did you test this code?

Updated tests and added for codecov.

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 2:43pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 2:43pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 2:43pm

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (16d1dda) to head (cefeb42).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3996      +/-   ##
==========================================
+ Coverage   96.21%   96.42%   +0.20%     
==========================================
  Files        1142     1145       +3     
  Lines       36724    37330     +606     
==========================================
+ Hits        35335    35994     +659     
+ Misses       1389     1336      -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 21, 2024

Uffizzi Preview deployment-52086 was deleted.

Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of minor comments.

api/organisations/models.py Outdated Show resolved Hide resolved
api/organisations/tasks.py Outdated Show resolved Hide resolved
Co-authored-by: Matthew Elwell <matthew.elwell@flagsmith.com>
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving here, but I'm not sure what's going on with the codecov workflow that seems stuck..

@zachaysan zachaysan added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit d86f8e7 May 28, 2024
23 of 24 checks passed
@zachaysan zachaysan deleted the fix/set_api_usage_billing_to_100k branch May 28, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants