Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Change Passwd by adding Gateway Passwd #1694

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Benouch
Copy link

@Benouch Benouch commented Aug 31, 2022

Hi there,
I've improved on the change password feature of Remmina.
I've added the ability to also change the Gateway Password in mass.
I don't know if this has ever been requested but for me it is an essential feature since I use Remmina for a professional purpose and of course my password changes every so often. And since I use a RD Gateway to connect to Windows servers changing my Gateway password had become a chore.
I've haven't created any translations for the new labels. I'll be happy to do it for languages I know.
Thank you.
FYI it's my first pull/merge request so let me know if what I'm doing is correct.

image

@giox069
Copy link
Contributor

giox069 commented Aug 31, 2022

Hi @Benouch , your patch is very interesting. But this github repository is only a secondary mirror of the main gitlab repository here: https://gitlab.com/Remmina/Remmina/
Could you please create the same MR in GitLab ?

Thank you.

@Benouch
Copy link
Author

Benouch commented Aug 31, 2022 via email

@Benouch
Copy link
Author

Benouch commented Aug 31, 2022 via email

@antenore
Copy link
Member

I believe I recreated the exact same thing on gitlab. Let me know if anything.

On Wed, Aug 31, 2022 at 3:59 PM Giovanni Panozzo @.> wrote: Hi @Benouch https://github.com/Benouch , your patch is very interesting. But this github repository is only a secondary mirror of the main gitlab repository here: https://gitlab.com/Remmina/Remmina/ Could you please create the same MR in GitLab ? Thank you. — Reply to this email directly, view it on GitHub <#1694 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6XV3N4643HVW3JS3C6Y7DV362RJANCNFSM6AAAAAAQBV4GIU . You are receiving this because you were mentioned.Message ID: @.>

We don't see it, can you please link the merge request?

@Benouch
Copy link
Author

Benouch commented Sep 1, 2022 via email

@antenore
Copy link
Member

antenore commented Sep 1, 2022

This is in your fork, you must submit a new MR at https://gitlab.com/Remmina/Remmina/-/merge_requests/new

@Benouch
Copy link
Author

Benouch commented Sep 1, 2022 via email

@giox069
Copy link
Contributor

giox069 commented Sep 1, 2022

If I'm not wrong, the correct procedure should be:

  1. In gitlab.com fork the main Remmina repository to your personal repository (and you already did it one time, I think)
  2. In your personal repository on gitlab create a new branch and add your code to this new branch
  3. Create a Merge Request from your repo/branch to the master branch of remmina repository (all in Gitlab)

@Benouch
Copy link
Author

Benouch commented Sep 1, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants