Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App window position #223

Open
rikublock opened this issue Jul 31, 2023 · 2 comments
Open

App window position #223

rikublock opened this issue Jul 31, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@rikublock
Copy link

rikublock commented Jul 31, 2023

Clicking the extension icon opens the app window (borderless, no menu) in place. Whereas using the API creates a popup-like app window (with border, menu) somewhere on the screen. (This behavior could be dependent on the OS)

Would be nice, if this was more consistent (especially the positioning). Ideally the icon app window is used for all cases.

Opened with icon (positioned next to icon):
app_borderless

Opened with API call (positioned somewhere top-left of screen):
app_border

@FlorianBouron
Copy link
Collaborator

Hi @rikublock ,
Thank you for the feedback, do you mean that you would put the window on the top right instead?
I see that it is actually what does Phantom,

@FlorianBouron FlorianBouron added the enhancement New feature or request label Aug 3, 2023
@FlorianBouron FlorianBouron self-assigned this Aug 3, 2023
@rikublock
Copy link
Author

Thank you for the feedback, do you mean that you would put the window on the top right instead?

Yeah pretty much. I would try to open the exact same window (same position) as if the user clicked the extension icon. Not sure what is happening behind the scene currently, but sort of looks like two different things are being used (popup window for API and extension window/menu for icon click).

I see that it is actually what does Phantom,

I think pretty much any extension does it. Metamask would be another (good) example.

It's probably not very high priority, but it's certainly annoying, if the window keeps jumping around the screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants