Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: code cleanup #2519

Draft
wants to merge 68 commits into
base: development
Choose a base branch
from

Conversation

brenoepics
Copy link

Description

Please carefully read the Contributing note and Code of conduct before making any pull requests.

Issues fixed by this PR

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

Collections.sort is just a wrapper, so it is better to use an instance method directly.
we can use computeIfAbsent here
brenoepics and others added 20 commits June 9, 2024 12:22
Bumps [com.google.protobuf:protoc](https://github.com/protocolbuffers/protobuf) from 3.18.1 to 4.27.1.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl)
- [Commits](https://github.com/protocolbuffers/protobuf/commits)

---
updated-dependencies:
- dependency-name: com.google.protobuf:protoc
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [com.fasterxml.jackson:jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.14.0 to 2.17.1.
- [Commits](FasterXML/jackson-bom@jackson-bom-2.14.0...jackson-bom-2.17.1)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson:jackson-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.jline:jline-terminal-jna](https://github.com/jline/jline3) from 3.21.0 to 3.26.1.
- [Release notes](https://github.com/jline/jline3/releases)
- [Changelog](https://github.com/jline/jline3/blob/master/changelog.md)
- [Commits](jline/jline3@jline-parent-3.21.0...jline-parent-3.26.1)

---
updated-dependencies:
- dependency-name: org.jline:jline-terminal-jna
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.junit.jupiter:junit-jupiter-engine](https://github.com/junit-team/junit5) from 5.8.2 to 5.10.2.
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.8.2...r5.10.2)

---
updated-dependencies:
- dependency-name: org.junit.jupiter:junit-jupiter-engine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…otobuf-protoc-4.27.1

chore(deps): bump com.google.protobuf:protoc from 3.18.1 to 4.27.1
….jackson-jackson-bom-2.17.1

chore(deps): bump com.fasterxml.jackson:jackson-bom from 2.14.0 to 2.17.1
…ne-terminal-jna-3.26.1

chore(deps): bump org.jline:jline-terminal-jna from 3.21.0 to 3.26.1
…iter-junit-jupiter-engine-5.10.2

chore(deps): bump org.junit.jupiter:junit-jupiter-engine from 5.8.2 to 5.10.2
Bumps [org.java-websocket:Java-WebSocket](https://github.com/TooTallNate/Java-WebSocket) from 1.5.2 to 1.5.6.
- [Release notes](https://github.com/TooTallNate/Java-WebSocket/releases)
- [Changelog](https://github.com/TooTallNate/Java-WebSocket/blob/master/CHANGELOG.md)
- [Commits](TooTallNate/Java-WebSocket@v1.5.2...v1.5.6)

---
updated-dependencies:
- dependency-name: org.java-websocket:Java-WebSocket
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ch.qos.logback:logback-core](https://github.com/qos-ch/logback) from 1.4.7 to 1.5.6.
- [Commits](qos-ch/logback@v_1.4.7...v_1.5.6)

---
updated-dependencies:
- dependency-name: ch.qos.logback:logback-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…k-logback-core-1.5.6

chore(deps): bump ch.qos.logback:logback-core from 1.4.7 to 1.5.6
…ocket-Java-WebSocket-1.5.6

chore(deps): bump org.java-websocket:Java-WebSocket from 1.5.2 to 1.5.6
Bumps org.slf4j:slf4j-api from 2.0.7 to 2.0.13.

---
updated-dependencies:
- dependency-name: org.slf4j:slf4j-api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…4j-api-2.0.13

chore(deps): bump org.slf4j:slf4j-api from 2.0.7 to 2.0.13
@@ -113,7 +113,7 @@ public void handle(GameSession session, byte[] header, byte[] payload) throws Ex
if (req.getKeyId() > 0) {
var encryptSeed = session.getEncryptSeed();
try {
var cipher = Cipher.getInstance("RSA/ECB/PKCS1Padding");
var cipher = Cipher.getInstance("RSA/ECB/OAEPWithSHA-256AndMGF1Padding");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you verify that this is compatible with the client or just apply suggestions from sonarcloud?
Because this has a high chance of breaking the ps. Same for the other crypto algorithm changes.

@@ -8,7 +8,7 @@

@ResourceType(name = "RewardPreviewExcelConfigData.json", loadPriority = LoadPriority.HIGH)
public class RewardPreviewData extends GameResource {
@Getter(onMethod_ = @Override)
@Getter(onMethod = @__(@Override))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the use of the legacy on method annotation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants