Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make name input optional in create-ikit-app #160

Open
IanMitchell opened this issue Oct 16, 2022 · 5 comments
Open

Make name input optional in create-ikit-app #160

IanMitchell opened this issue Oct 16, 2022 · 5 comments
Labels
Feature New things ✨ Help Wanted Additional information is required or community contributions are encouraged
Projects
create-ikit-app
Milestone
create-ikit-app R...

Comments

@IanMitchell
Copy link
Owner

Right now if you don't provide a top level name the command fails. Instead, it should prompt for a name if none is given
@IanMitchell IanMitchell added the Feature New things ✨ label Oct 16, 2022
@IanMitchell IanMitchell added this to the create-ikit-app Release milestone Oct 16, 2022
@IanMitchell IanMitchell added this to To do in create-ikit-app via automation Oct 16, 2022
@IanMitchell IanMitchell added the Help Wanted Additional information is required or community contributions are encouraged label Oct 16, 2022
@IanMitchell IanMitchell pinned this issue Oct 16, 2022
@IanMitchell
Copy link
Owner Author

Pinning this as a good first issue for potential contributors. To test this, run:

cd packages/create-ikit-app
npm run build
./dist/cli.js

@thewilloftheshadow
Copy link

This doesn't look to be possible without forking create-create-app
https://github.com/uetchy/create-create-app/blob/master/src/index.ts#L250

@IanMitchell
Copy link
Owner Author

Hm, time to throw up a PR I guess!

@IanMitchell
Copy link
Owner Author

Looks like plop or something like https://github.com/vitejs/vite/blob/main/packages/create-vite/src/index.ts would be good alternatives

@thewilloftheshadow
Copy link

I can take on converting the create-create-app code to this. Which one do you prefer me to use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New things ✨ Help Wanted Additional information is required or community contributions are encouraged
Projects
create-ikit-app
To do
Milestone
create-ikit-app Release
Development

No branches or pull requests
2 participants
@IanMitchell @thewilloftheshadow