Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify luos_engine compilation as a shared lib #474

Draft
wants to merge 2 commits into
base: rc_3.1.0
Choose a base branch
from

Conversation

nicolas-rabault
Copy link
Member

@nicolas-rabault nicolas-rabault commented Feb 1, 2024

By submiting this PR, you agree with the associated license MIT) and with our Contributor License Agreement (CLA).

Before to begin

Thank you for contributing to the Luos project!

Before to begin, please follow these steps:

  • Ensure that this PR is not a duplicate.

Feel free to read the Luos contribution's guidelines and the documentation page to have more insight about how to contribute to Luos.

PR Description section

Description and dependencies

Please include here a summary of the changes and the related issue. List any dependencies that are required for this change.

Changes

Please choose the relevant options:

  • New feature (non-breaking change which adds functionality)

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.


WARNING: Do not edit the checklist below.


Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@nicolas-rabault nicolas-rabault added this to the 3.1.0 milestone Feb 1, 2024
@nicolas-rabault nicolas-rabault self-assigned this Feb 1, 2024
@nicolas-rabault nicolas-rabault changed the base branch from main to rc_3.1.0 February 1, 2024 13:55
@nicolas-rabault nicolas-rabault changed the title Simplify luos_engine as a shared lib compilation Simplify luos_engine compilation as a shared lib Feb 1, 2024
@nicolas-rabault
Copy link
Member Author

@nicolas-rabault nicolas-rabault removed this from the 3.1.0 milestone Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant