Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume album as folder when album missing #356

Open
4 tasks done
occasionallyword opened this issue Feb 12, 2023 · 4 comments
Open
4 tasks done

Don't assume album as folder when album missing #356

occasionallyword opened this issue Feb 12, 2023 · 4 comments
Assignees
Labels
blocked Currently blocked by another task enhancement New feature or request music Related to music loading

Comments

@occasionallyword
Copy link

Description

I would like for Auxio to not automatically assign an Album to songs when no album is given in the metadata. I would like a setting for this behavior, instead of assuming it intentionally.

Currently, some of my library has Title and Artist metadata, but lacks Album metadata. Auxio will automatically display the Album as the name of the folder which my music is stored in on the, "Now Playing" screen. I understand that some people store music and separate albums by folders, but this functionality should probably be a setting inside of Auxio.

Problem solved

No response

Other implementations

In my experience, other players will either provide a setting for this behavior instead of assuming it, or will only display Album data when present within the tags of the individual song.

Benefit

This will benefit everyone's usage of Auxio by not providing an incorrect tag when no tag is present in the file. A setting to determine this behavior makes logical sense, and would satisfy the needs of people who group things by folders/directories as well as by tags themselves.

Duplicates

@OxygenCobalt
Copy link
Owner

This is not under my control, and is actually from the media database automatically assigning the folder name to music. I also can't do my own filtering, as that will lead to collisions. For example, if an album has the name "0", is it because it's from audio files in /storage/emulated/0, or is it because the songs are from Low Roar's Album "0"?

#322 should allow me to turn this behavior into a toggle. However, I'm not sure how to handle the fallback album case. Either:

  • All songs without an album name are grouped into "Unknown Album" instances. This is easy to do.
  • All songs without an album name just don't have an album at all. This is a thing I can do, but it also breaks one of the core invariants of Auxio's music model and requires a bunch more work.

@occasionallyword
Copy link
Author

occasionallyword commented Feb 12, 2023

I understand, thanks for the explanation.

It's not a massive problem for me, just a minor annoyance sometimes with how album art is treated from #342 mostly. I figured I could at least make an issue for it to document it.

@OxygenCobalt
Copy link
Owner

Ah, okay. Definitely something I could see doing though, so I'll keep this open.

@OxygenCobalt OxygenCobalt added music Related to music loading blocked Currently blocked by another task labels Feb 15, 2023
@OxygenCobalt
Copy link
Owner

#585 requested an additional option to interpret songs without an album as a single. This is possible, given that this is already configuration-controlled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Currently blocked by another task enhancement New feature or request music Related to music loading
Projects
Status: v4.1.0
Development

No branches or pull requests

2 participants