Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Moderation Console E2E #32608

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

test: Moderation Console E2E #32608

wants to merge 5 commits into from

Conversation

csuadev
Copy link
Contributor

@csuadev csuadev commented Jun 14, 2024

Add e2e tests for the moderation console.

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-509

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jun 14, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 14, 2024

⚠️ No Changeset found

Latest commit: 1d760be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@csuadev csuadev added this to the 6.10 milestone Jun 14, 2024
@csuadev csuadev requested a review from dougfabris June 14, 2024 11:36
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA skipped labels Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.44%. Comparing base (97eaa17) to head (c59ed8f).
Report is 68 commits behind head on develop.

Current head c59ed8f differs from pull request most recent head 1d760be

Please upload reports for the commit 1d760be to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32608      +/-   ##
===========================================
- Coverage    56.48%   56.44%   -0.05%     
===========================================
  Files         2455     2510      +55     
  Lines        54100    55146    +1046     
  Branches     11149    11374     +225     
===========================================
+ Hits         30559    31126     +567     
- Misses       20890    21308     +418     
- Partials      2651     2712      +61     
Flag Coverage Δ
e2e 56.03% <ø> (-0.19%) ⬇️
e2e-api 41.25% <ø> (-0.08%) ⬇️
unit 72.22% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@csuadev csuadev marked this pull request as ready for review June 14, 2024 12:23
@csuadev csuadev requested a review from a team as a code owner June 14, 2024 12:23
apps/meteor/tests/e2e/moderation.spec.ts Outdated Show resolved Hide resolved
apps/meteor/tests/e2e/moderation.spec.ts Outdated Show resolved Hide resolved
apps/meteor/tests/e2e/moderation.spec.ts Outdated Show resolved Hide resolved
apps/meteor/tests/e2e/moderation.spec.ts Outdated Show resolved Hide resolved
apps/meteor/tests/e2e/page-objects/moderation.ts Outdated Show resolved Hide resolved
apps/meteor/tests/e2e/moderation.spec.ts Outdated Show resolved Hide resolved
apps/meteor/tests/e2e/moderation.spec.ts Outdated Show resolved Hide resolved
apps/meteor/tests/e2e/page-objects/moderation.ts Outdated Show resolved Hide resolved
apps/meteor/tests/e2e/page-objects/moderation.ts Outdated Show resolved Hide resolved
apps/meteor/tests/e2e/moderation.spec.ts Outdated Show resolved Hide resolved
@csuadev csuadev requested a review from dougfabris June 14, 2024 16:32
@csuadev csuadev requested a review from dougfabris June 18, 2024 19:49
Copy link
Contributor

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to test all the behaviors in the moderation console. What do you think?

There are some available options for the admin, (dismiss, delete all messages deactivate user, etc). Do you think it would be possible to test them all? Or at least the ones we can simulate through the test environment...

@scuciatto scuciatto removed this from the 6.10 milestone Jun 19, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 19, 2024
@csuadev csuadev marked this pull request as draft June 21, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants