Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: removing meteor dependencies from action buttons #32646

Draft
wants to merge 6 commits into
base: release-7.0.0
Choose a base branch
from

Conversation

debdutdeb
Copy link
Member

@debdutdeb debdutdeb commented Jun 20, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

totally wip, not worth reviewing at this point

this is a poc - due discussion in chapter meeting. alternative I thought of was mimicking meteor methods, basically a setting action namespaced methods indexed by setting value much like it is now. started with the current approach as it tied in together quite well in my mind, action settings and their triggers together.

Copy link
Contributor

dionisio-bot bot commented Jun 20, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 20, 2024

⚠️ No Changeset found

Latest commit: df7bbcf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 57.69231% with 11 lines in your changes missing coverage. Please review.

Project coverage is 56.47%. Comparing base (76951f5) to head (df7bbcf).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #32646      +/-   ##
=================================================
- Coverage          56.68%   56.47%   -0.21%     
=================================================
  Files               2492     2461      -31     
  Lines              55308    54260    -1048     
  Branches           11448    11168     -280     
=================================================
- Hits               31351    30646     -705     
+ Misses             21255    21004     -251     
+ Partials            2702     2610      -92     
Flag Coverage Δ
unit 71.80% <57.69%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@casalsgh casalsgh added this to the 7.0 milestone Jun 21, 2024
@debdutdeb debdutdeb changed the base branch from develop to release-7.0.0 June 25, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants