Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding license number to player information #442

Open
ozgurun opened this issue May 6, 2023 · 3 comments
Open

Adding license number to player information #442

ozgurun opened this issue May 6, 2023 · 3 comments

Comments

@ozgurun
Copy link

ozgurun commented May 6, 2023

The easiest way to distinguish players with the same name and surname in a league application under a federation structure is to give each player an identification number. This is the license number given according to the player’s branch record.
It will be useful to add a license number to the add player section.

It can be made easier by adding player cvs to the download list.

class-sp-admin-cpt-player.php
line
79
106
259-289
366-367

class-sp-meta-box-player-details.php
line
27
87-88
207

class-sp-player-importer
line
28
149-150

Player.zip

@savvasha
Copy link
Collaborator

savvasha commented May 7, 2023

Hi @ozgurun ,

That is a very interesting idea! Is it possible to make those additions with a Pull Request instead? It will be easier for our devs to test it :)

Thanks,
Savvas

@ozgurun
Copy link
Author

ozgurun commented May 7, 2023

Hi @savvasha

Yes, this test will be appropriate.

At the moment, I think it will be easier in match team rosters to add team rosters, players and staff with this license number on the match page.

For this, I plan to add the team players playing in the match to the squad list with the license number and the Add button instead of selecting the checbox and adding them after the update.

Player Add

Thanks
Best regards
Özgur

@ozgurun
Copy link
Author

ozgurun commented May 18, 2023

Hi;

It seems easier to use licenseno in pull requests.
When adding a new player, it is necessary to assign it as a pull id.

When adding a new player, an automatic ID must be created first.
When licenseno is entered, licenseno must be updated as id

Player id with existing automatic id generation
[player_details 10345] and [player_statistics 10345]

Possible status after change
[player_details "licenseno"] and [player_statistics "licenseno"]

Thanks
Özgür

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants