Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support send to multiple topics #261

Closed
vibgy opened this issue Jul 18, 2016 · 7 comments
Closed

Support send to multiple topics #261

vibgy opened this issue Jul 18, 2016 · 7 comments

Comments

@vibgy
Copy link
Contributor

vibgy commented Jul 18, 2016

FCM has introduced a way to send notification to multiple topics using the "condition" parameter in send API.
Ref: https://firebase.google.com/docs/cloud-messaging/http-server-ref

@eladnava
Copy link
Collaborator

@vibgy Excellent PR!

However, could it be better to introduce a brand new recipient key condition instead of piggybacking on the topic parameter? @hypesystem

@vibgy
Copy link
Contributor Author

vibgy commented Jul 19, 2016

@eladnava Thank you.
Let me know.. I was also debating if I should introduce "condition" or not. If you guys want me to change it, I'm happy to do so. But today is a busy day for me. I can do it tomorrow.

@hypesystem
Copy link
Collaborator

Cool that this has been introduced! I think we should use the "condition" parameter.

This might complicate the interface for v1 or force us to rethink some things. (See and discuss at #238)

@hypesystem
Copy link
Collaborator

I should clarify: let's use "condition" as it is closer to the underlyibg interface :)

Don't forget to add yourself as contributor in the package :)

@vibgy
Copy link
Contributor Author

vibgy commented Jul 20, 2016

Sure.. I'll update the PR. Thank you @hypesystem !

@vibgy
Copy link
Contributor Author

vibgy commented Jul 20, 2016

I updated the PR. Please review. Thanks you @hypesystem @eladnava ..

@eladnava
Copy link
Collaborator

eladnava commented Oct 3, 2016

PR has been merged. Thanks for your hard work!

@eladnava eladnava closed this as completed Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants