Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account_objects does not report error when "type" is not account related objects #1488

Open
cindyyan317 opened this issue Jun 24, 2024 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@cindyyan317
Copy link
Collaborator

account_objects should return error when filter is not account related, such as "fee".
Clio previously reported error correctly. Now it doesn't report error which is a bug.
rippled has an issue to align this behavior with Clio.
We need to bring the correct behavior back.

Steps to Reproduce

{
  "method": "account_objects",
  "params": [
    {
        "account":"ra1egD7jzyZWhcDaPD1eFPKzdSMVQCTsXM",
        "type":"fee"
    }
  ]
}

Expected Result

{
  "result": {
    "error": "invalidParams",
    "error_code": 31,
    "error_message": "Invalid field 'type'.",
    "status": "error",
    "type": "response"
...
}

Actual Result

{
  "result": {
    "ledger_hash": "B77D03F5E422F488E3F41178F2B71C7A27A98B013225670C91C00A060392B277",
    "ledger_index": 1844337,
    "validated": true,
    "limit": 200,
    "account": "ra1egD7jzyZWhcDaPD1eFPKzdSMVQCTsXM",
    "account_objects": [],
    "status": "success"
  },
  "warnings": [
    [],
    {
      "id": 2001,
      "message": "This is a clio server. clio only serves validated data. If you want to talk to rippled, include 'ledger_index':'current' in your request"
    }
  ]
}

Environment

devnet

@cindyyan317 cindyyan317 added the bug Something isn't working label Jun 24, 2024
@kuznetsss kuznetsss added this to the 2.3 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants