Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure #1

Open
1 task
a-givertzman opened this issue Dec 12, 2022 · 1 comment · May be fixed by #4
Open
1 task

Failure #1

a-givertzman opened this issue Dec 12, 2022 · 1 comment · May be fixed by #4

Comments

@a-givertzman
Copy link
Owner

  • Must extends Exception class and support the chain of the failures
   Failure(
      String message: message,
      Failure failure: failure,
      StackTrace stackTrace: stackTrace,
   )
@Minyewoo Minyewoo linked a pull request Dec 19, 2022 that will close this issue
Failure #4
Open
@Minyewoo
Copy link
Collaborator

Why do we need to have stackTrace inside failures, if they will be built in a chain? We will have many stackTrace copies with minor differences.

Wouldn't it be better if we take stackTrace to another place, where we'll catch the root failure and fetch StackTrace instance only once?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
CMA
Status: 🟢 Priority 3
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Failure a-givertzman/hmi_core
2 participants
@Minyewoo @a-givertzman