Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: First time developer setup #1677

wants to merge 3 commits into
base: develop
Choose a base branch


Copy link

While setting up the dev environment for the first time, I ran into some issues. This PR fixes .env.example to help future developers.

  1. There was an error that the database doesn't exist. Adding POSTGRES_DB silenced the error. I don't know if this is absolutely required but it doesn't hurt.
  2. The nginx container (pulled from Docker Hub) expects CERT_PUB_KEY and CERT_PRIV_KEY to be base64 encoded
  3. While using the certs to setup a complete HTTPS environment, the frontend kept generating an error. Adding CORS_ORIGIN_WHITELIST helped along with the corresponding change in tacticalrmm-web (separate PR).

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (564aaaf) 80.93% compared to head (2cf1c0d) 80.85%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1677      +/-   ##
- Coverage    80.93%   80.85%   -0.09%     
  Files          136      136              
  Lines         9218     9228      +10     
  Hits          7461     7461              
- Misses        1757     1767      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NiceGuyIT NiceGuyIT marked this pull request as ready for review November 12, 2023 21:36
@wh1te909 wh1te909 requested a review from sadnub November 14, 2023 00:46
Copy link

@sadnub sadnub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants