Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase the security of passwords at mesh #882

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

MalteKiefer
Copy link

No description provided.

install.sh Outdated
"reset": 90,
"force2factor": false,
"oldPasswordBan": 5,
"banCommonPasswords": false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason not to make this true?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I will fix it, give me a second

@wh1te909
Copy link
Member

have you tested this with the install script? I believe it will break it atm due to this https://github.com/wh1te909/tacticalrmm/blob/983a5c2034c9e3b58c5e1bb8e291821d29c241eb/install.sh#L82 password is randomly generated and doesn't include non alpha chars

@bbrendon
Copy link
Contributor

@silversword411
Copy link
Collaborator

Reset 90?

Didn't notice that, but if
"reset": 90, requires password reset every 90 days it won't affect the token...but that should probably be removed.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Malte Kiefer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@wh1te909 wh1te909 force-pushed the develop branch 2 times, most recently from 942055f to 903a2d6 Compare June 25, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants