Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

di_BingingParam Unit Test failure #57

Open
pjspenceley opened this issue Dec 15, 2019 · 3 comments
Open

di_BingingParam Unit Test failure #57

pjspenceley opened this issue Dec 15, 2019 · 3 comments
Assignees
@ImJohnMDaniel
Labels
bug Something isn't working

Comments

@pjspenceley
Copy link

When running the unit tests, I'm getting a failure for: di_BingingParamTest.givenStringsWhenGetParameterThenGetValues(), line 302...

System.assertEquals( testDateTime.dateGmt(), response.dateTimeValue ); // hours will be zero'ed out

I'm in NZ Summer Time time zone. The expected value: 2018-08-07, actual value: 2018-08-08
Running this at 8:00 am in NZ
@afawcett afawcett mentioned this issue Dec 28, 2019
Merged
@afawcett afawcett added the bug Something isn't working label Dec 28, 2019
@afawcett
Copy link
Collaborator

@pjspenceley I have produced a PR to fix this and copied in @ImJohnMDaniel to review.

@ImJohnMDaniel
Copy link
Collaborator

@pjspenceley , The PR that @afawcett was referring to has been merged. Can you take the update please and let us know if we can close this issue?

@ImJohnMDaniel ImJohnMDaniel self-assigned this Dec 28, 2019
@dieffrei
Copy link

dieffrei commented May 5, 2021

I had the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ImJohnMDaniel ImJohnMDaniel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ImJohnMDaniel @afawcett @dieffrei @pjspenceley