Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JointDistribution wraps and unwraps X and Y #161

Open
pawel-czyz opened this issue Jun 27, 2024 · 1 comment · May be fixed by #165
Open

JointDistribution wraps and unwraps X and Y #161

pawel-czyz opened this issue Jun 27, 2024 · 1 comment · May be fixed by #165
Labels
🔩 type: refactor Refactoring the code

Comments

@pawel-czyz
Copy link
Member

Currently the JointDistribution wraps and unwraps X and Y samples into one array XY by concatenation and slicing.

This is suboptimal: for example, X and Y need to have the same dtype and working with continuous and categorical variables requires manual casting.

Instead, we can use JointDistribution from TFP on JAX.

@pawel-czyz pawel-czyz added the 🔩 type: refactor Refactoring the code label Jun 28, 2024
@pawel-czyz
Copy link
Member Author

This has to be implemented after #143 has been resolved.

It should be then a minor change, as there's a Split bijector in TFP on JAX.

This was referenced Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 type: refactor Refactoring the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant