Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up imports #76

Open
grfrederic opened this issue Apr 17, 2023 · 1 comment
Open

Clean up imports #76

grfrederic opened this issue Apr 17, 2023 · 1 comment
Labels
🔥 priority: low 🔩 type: refactor Refactoring the code

Comments

@grfrederic
Copy link
Collaborator

We've made a lot of changes when moving to our new tasks/benchmark API. It would be nice to rethink which tasks/estimators etc should be exported by default. For example:

  1. when importing bmi.benchmark, should functions for creating tasks (which live in bmi.benchmark.tasks) be reexported there and users create the tasks themselves, or should the tasks from the benchmark list be reexported under convenient names?
  2. should external estimators be exported separately, or included in bmi.estimators? we could go with the latter and raise warnings when someone tries to initialize an estimator and R/julia/some necessary packages is not installed.
@pawel-czyz
Copy link
Member

@grfrederic what should we do with this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔥 priority: low 🔩 type: refactor Refactoring the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pawel-czyz @grfrederic