Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create sk-SK.h #2091

Merged
merged 2 commits into from
May 12, 2024
Merged

Create sk-SK.h #2091

merged 2 commits into from
May 12, 2024

Conversation

misa1515
Copy link
Contributor

Slovak language

Comment on lines 4 to 5
#ifndef LOCALE_SK-SK_H_
#define LOCALE_SK-SK_H_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the build failure says, that dash - should be an underscore _...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

src/locale/sk-SK.h:4:  #ifndef header guard has wrong style, please use: LOCALE_SK_SK_H_  [build/header_guard] [5]
src/locale/sk-SK.h:3[9](https://github.com/crankyoldgit/IRremoteESP8266/actions/runs/8870139943/job/24351598938?pr=2091#step:6:10)3:  #endif line should be "#endif  // LOCALE_SK_SK_H_"  [build/header_guard] [5]

"Tomuto výsledku by sa nemalo dôverovať, kým sa to nevyrieši. " \
"Upraviť a zväčšiť `kCaptureBufferSize`."

#endif // LOCALE_SK-SK_H_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same error as at the top...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/locale/sk-SK.h:4:  #ifndef header guard has wrong style, please use: LOCALE_SK_SK_H_  [build/header_guard] [5]
src/locale/sk-SK.h:3[9](https://github.com/crankyoldgit/IRremoteESP8266/actions/runs/8870139943/job/24351598938?pr=2091#step:6:10)3:  #endif line should be "#endif  // LOCALE_SK_SK_H_"  [build/header_guard] [5]

Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for adding this. Great effort! Just a few fixes and some stuff you should be able to remove.

"Tomuto výsledku by sa nemalo dôverovať, kým sa to nevyrieši. " \
"Upraviť a zväčšiť `kCaptureBufferSize`."

#endif // LOCALE_SK-SK_H_
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/locale/sk-SK.h:4:  #ifndef header guard has wrong style, please use: LOCALE_SK_SK_H_  [build/header_guard] [5]
src/locale/sk-SK.h:3[9](https://github.com/crankyoldgit/IRremoteESP8266/actions/runs/8870139943/job/24351598938?pr=2091#step:6:10)3:  #endif line should be "#endif  // LOCALE_SK_SK_H_"  [build/header_guard] [5]

Comment on lines 17 to 18
#define D_STR_TURBO "Turbo"
#define D_STR_SUPER "Super"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When they are the same as the default, please don't include them.
i.e. You should be able to remove these two lines.

#define D_STR_LIGHT "Svetlo"
#define D_STR_POWERFUL "Výkonný"
#define D_STR_QUIET "Tichý"
#define D_STR_ECONO "Econo"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

#define D_STR_FILTER "Filter"
#define D_STR_3D "3D"
#define D_STR_CELSIUS "Celzia"
#define D_STR_FAHRENHEIT "Fahrenheit"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto. Remove

Comment on lines 65 to 66
#define D_STR_START "Štart"
#define D_STR_STOP "Stop"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, remove these two.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Štart is not Start 😉

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Yeah, just remove Stop

#define D_STR_DISPLAY "Displej"
#define D_STR_WEEKLY "Týždenne"
#define D_STR_WEEKLYTIMER D_STR_WEEKLY " " D_STR_TIMER // Needs `D_STR_WEEKLY`!
#define D_STR_WIFI "WiFi"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto. Remove WiFi

Comment on lines 123 to 126
#define D_STR_MAX "Max"
#define D_STR_MAXIMUM "Maximum"
#define D_STR_MIN "Min"
#define D_STR_MINIMUM "Minimum"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these four.

Comment on lines 197 to 198
#define D_STR_TRUE "True"
#define D_STR_FALSE "False"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these two.

Comment on lines 202 to 226

// Model Names
#define D_STR_YAW1F "YAW1F"
#define D_STR_YBOFB "YBOFB"
#define D_STR_YX1FSF "YX1FSF"
#define D_STR_V9014557_A "V9014557-A"
#define D_STR_V9014557_B "V9014557-B"
#define D_STR_RLT0541HTA_A "R-LT0541-HTA-A"
#define D_STR_RLT0541HTA_B "R-LT0541-HTA-B"
#define D_STR_ARRAH2E "ARRAH2E"
#define D_STR_ARDB1 "ARDB1"
#define D_STR_ARREB1E "ARREB1E"
#define D_STR_ARJW2 "ARJW2"
#define D_STR_ARRY4 "ARRY4"
#define D_STR_ARREW4E "ARREW4E"
#define D_STR_GE6711AR2853M "GE6711AR2853M"
#define D_STR_AKB75215403 "AKB75215403"
#define D_STR_AKB74955603 "AKB74955603"
#define D_STR_AKB73757604 "AKB73757604"
#define D_STR_LG6711A20083V "LG6711A20083V"
#define D_STR_KKG9AC1 "KKG9AC1"
#define D_STR_KKG29AC1 "KKG29AC1"
#define D_STR_LKE "LKE"
#define D_STR_NKE "NKE"
#define D_STR_DKE "DKE"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to remove all the model & protocol names.

@crankyoldgit crankyoldgit self-assigned this May 12, 2024
Review feedback corrections.
@crankyoldgit crankyoldgit self-requested a review May 12, 2024 11:03
@crankyoldgit crankyoldgit merged commit 32d10a6 into crankyoldgit:master May 12, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants