Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIGHUP is not triggering a reload of transformers #375

Closed
arvchristos opened this issue Aug 15, 2023 · 3 comments
Closed

SIGHUP is not triggering a reload of transformers #375

arvchristos opened this issue Aug 15, 2023 · 3 comments
Labels
enhancement New feature or request
Milestone
v0.38.0

Comments

@arvchristos
Copy link
Contributor

Hello,

Thank you for the wonderful project.

It seems that sending a SIGHUP to the go-dnscollector process is not triggering a full config reload. In particular, I tested this by setting a file in keep-domain-file transform, testing that this works, then adding a new domain there and sending a SIGHUP. Then, the newly added domain was not taken into account.

Is this by design ? This functionality would really help us fetching lists from various sources (e.g. MISP) and triggering a reload for the config.

Thank you in advance!
@dmachard
Copy link
Owner

Hi,
Thanks for your support.

The config reload is partial right now, all settings referring to an external file are not reloaded .
I will take a look to see how to properly reload all actives transforms on SIGHUP and come back to you.

In meantime, any contributions are welcome to improve this project :)

@dmachard dmachard added the enhancement New feature or request label Aug 17, 2023
@dmachard dmachard mentioned this issue Oct 24, 2023
Merged
@dmachard
Copy link
Owner

FYI, full reload of the configuration is planned for next release

@dmachard dmachard added this to the v0.38.0 milestone Oct 26, 2023
@dmachard
Copy link
Owner

beta release available https://github.com/dmachard/go-dnscollector/releases/tag/v0.38.0-beta1
Any feedback will be appreciated!

@dmachard dmachard closed this as completed Nov 2, 2023
@arvchristos arvchristos mentioned this issue Feb 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.38.0
Development

No branches or pull requests
2 participants
@arvchristos @dmachard