Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlyoutIcon does not show in alternate theme #20392

Open
vsfeedback opened this issue Feb 6, 2024 · 5 comments
Open

FlyoutIcon does not show in alternate theme #20392

vsfeedback opened this issue Feb 6, 2024 · 5 comments
Labels
area-controls-flyout Flyout platform/android 🤖 platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@vsfeedback
Copy link

This issue has been moved from a ticket on Developer Community.


In my brand new, plain vanilla MAUI app, standard flyout icon appears in normal, light windows mode (theme), while in dark mode does not appear. Also, the same application run on my locally connected android phone shows standard flyout icon in dark theme, but not in light theme. Explicitly setting icon with:

FlyoutIcon="{AppThemeBinding Dark=dotnet_bot.png, Light=dotnet_bot2.png}"

helps in dark mode on windows, but still does not work on android in light theme. Everything was done in debug mode (plain F5), and also in release mode on android. Android problem was confirmed on another android phone (of my friend, who prefers light theme) of different make, installed from release .apk file. Nothing helps. Windows 10, updated regularly, latest VS 2022, Samsung A12 android, updated regularly.


Original Comments

Feedback Bot on 2/4/2024, 11:43 PM:

(private comment, text removed)


Original Solutions

(no solutions)

@jsuarezruiz jsuarezruiz added t/bug Something isn't working area-controls-flyout Flyout labels Feb 7, 2024
@PureWeen PureWeen added the s/needs-repro Attach a solution or code which reproduces the issue label Feb 8, 2024
@ghost
Copy link

ghost commented Feb 8, 2024

Hi @vsfeedback. We have added the "s/needs-repro" label to this issue, which indicates that we require steps and sample code to reproduce the issue before we can take further action. Please try to create a minimal sample project/solution or code samples which reproduce the issue, ideally as a GitHub repo that we can clone. See more details about creating repros here: https://github.com/dotnet/maui/blob/main/.github/repro.md

This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

@PureWeen
Copy link
Member

PureWeen commented Feb 8, 2024

are you changing the theme while the app is running?

@gjuwindev
Copy link

  1. create a new, plain vanilla MAUI project (.NET 8, Win 10, VS 2022 Community)
  2. set Shell.FlyoutBehavior="Flyout" (from "Disabled", in AppShell.xaml)
  3. debug run that app it on Android phone in dark mode (and see the hamburger icon there)
  4. debug run that app it on Android phone in light mode (and the hamburger icon there IS MISSING)

in the meantime, I have found the solution and described it at:

 https://mudrac.ffzg.hr/~pgklada/corner/MissingShellIconOnAndroidInLightTheme.html

but it would be nice if that was not the problem in the plain vanilla MAUI project in the first place... I've spent days trying to find the solution somewhere :-)

@ghost ghost added s/needs-attention Issue has more information and needs another look and removed s/needs-repro Attach a solution or code which reproduces the issue labels Feb 9, 2024
@gjuwindev
Copy link

additional comment:

that change of foreground color still did not help if I try to use other ways to define Shell.FlyoutIcon, like:

<Shell.FlyoutIcon>
    <!--<FontImageSource 
        FontFamily="OpenSansRegular"
        Glyph="&#x40;"
        ></FontImageSource>-->
    <FileImageSource
        File="dotnet_bot.png"
        ></FileImageSource>
</Shell.FlyoutIcon>

no flyouticon on android in the light theme

@XamlTest XamlTest added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed platform/macOS 🍏 macOS / Mac Catalyst platform/android 🤖 platform/iOS 🍎 labels Mar 18, 2024
@XamlTest
Copy link
Collaborator

XamlTest commented Mar 18, 2024

Verified this on VS 17.10.0 Preview 2.0(8.0.7). Repro on Android 14.0-API34, iOS 17.2 and MacCatalyst, not repro on Windows 11 with below Project:
FlyoutIcon.zip

Issue only happens on Light mode.
image
Works fine on Dark mode.
image

@jsuarezruiz jsuarezruiz removed the s/needs-attention Issue has more information and needs another look label Jun 6, 2024
@jsuarezruiz jsuarezruiz added this to the Backlog milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-flyout Flyout platform/android 🤖 platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants