Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean build artifacts #60

Closed
nettnikl opened this issue Jul 8, 2023 · 1 comment · Fixed by #69
Closed

Clean build artifacts #60

nettnikl opened this issue Jul 8, 2023 · 1 comment · Fixed by #69

Comments

@nettnikl
Copy link
Contributor

nettnikl commented Jul 8, 2023

Hi,

i see that the build artifacts of the current release (https://github.com/emuell/restic-browser/releases/download/v0.2.5/Restic-Browser-v0.2.5-linux.tar.gz) do contain .DS_Store files. These do not contain any useful information. You might want to remove those from the releases.

Also, could you explain, how it gets there anyways? I see that the github actions created artifact (https://github.com/emuell/restic-browser/suites/12710716642/artifacts/697299798) does not have this issue. I cannot see the original artifact (https://github.com/emuell/restic-browser/actions/runs/3504122259/workflow), so i cannot verify if a new release would behave the same. Do you manually repack the artifacts? If so, is there a reason not to automate that?

Br!

@emuell
Copy link
Owner

emuell commented Jul 13, 2023

Also, could you explain, how it gets there anyways?

I've just repackaged it for cosmetic reasons:

  • skipping /bin folders
  • include the version number in the filename
  • Use zip compression for Windows and OSX

Doing this on an OSX machine will add those ugly DS_Store files unless you manually remove them.

I agree that ideally this should be done in the workflow scripts. I'll give it a try, also to make it easier to create new releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants