Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ethdebug] Transport debug data through block flattener. #15087

Conversation

aarlt
Copy link
Member

@aarlt aarlt commented May 9, 2024

Depends on #14969 and #15009.

(#15009 is just cherry-picked here and should be removed once merged)

See https://notes.ethereum.org/lznAP49lRj6zrLJdLpkqwg.

Block Flattening

Effect

{
    {   
        ...A...
    }
    {
        ...B...
    }
}

--->

{
    ...A...
    ...B...
}

Relevance

None. Scopes in yul don't carry any information relevant to ethdebug.

Implementation

This PR just adds a simple test. No additional logic for the treatment of debug attributes needed.

@aarlt aarlt added the has dependencies The PR depends on other PRs that must be merged first label May 9, 2024
@aarlt aarlt marked this pull request as draft May 9, 2024 11:23
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label May 23, 2024
@github-actions github-actions bot closed this May 31, 2024
@aarlt aarlt removed stale The issue/PR was marked as stale because it has been open for too long. closed-due-inactivity labels Jun 10, 2024
@aarlt aarlt reopened this Jun 10, 2024
@ethereum ethereum deleted a comment from github-actions bot Jun 10, 2024
@ethereum ethereum deleted a comment from github-actions bot Jun 10, 2024
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jun 25, 2024
@aarlt aarlt removed the stale The issue/PR was marked as stale because it has been open for too long. label Jun 25, 2024
@ethereum ethereum deleted a comment from github-actions bot Jun 25, 2024
@aarlt aarlt force-pushed the yul_transport_debugdata_attributes_to_assembly_items branch 5 times, most recently from 88e6b57 to bbcce99 Compare July 10, 2024 13:49
@aarlt aarlt force-pushed the yul_transport_debugdata_attributes_to_assembly_items branch 4 times, most recently from f52ac21 to 9ad6a0d Compare July 11, 2024 05:49
@aarlt
Copy link
Member Author

aarlt commented Jul 11, 2024

not needed

@aarlt aarlt closed this Jul 11, 2024
@aarlt aarlt deleted the transport_debug_data_through_block_flattener branch July 11, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has dependencies The PR depends on other PRs that must be merged first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant