Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Enforce Fluentd tests using SecretKeySelector #1108

Closed
antrema opened this issue Apr 5, 2024 · 1 comment · Fixed by #1109
Closed

Feat: Enforce Fluentd tests using SecretKeySelector #1108

antrema opened this issue Apr 5, 2024 · 1 comment · Fixed by #1109

Comments

@antrema
Copy link
Collaborator

antrema commented Apr 5, 2024

Is your feature request related to a problem? Please describe.

The tests cannot actually include SecretKeySelector as SecretLoader is not implemented for tests

Describe the solution you'd like

Change SecretLoader to interface and implement this interface into the tests

Additional context

No response
@antrema
Copy link
Collaborator Author

antrema commented Apr 5, 2024

I will propose a PR to change this behavior

@antrema antrema mentioned this issue Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement SecretLoader as interface and enforce Fluentd tests u… antrema/fluent-operator
1 participant
@antrema