Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified/new files after bench update is run. #850

Open
dlaufen opened this issue May 29, 2024 · 0 comments
Open

Modified/new files after bench update is run. #850

dlaufen opened this issue May 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dlaufen
Copy link

dlaufen commented May 29, 2024

I had been working of a fork of lms/main, but I decided to test lms/develop to see what is coming.

After pulling the latest from lms/develop branch and running "bench update" I am seeing a few modified/new files in the lms folders. I suspect something be wrong with .gitigore or perhaps missing a check in?

git status
On branch f_lms_develop
Your branch is up to date with 'origin/f_lms_develop'.     ##(this is my unmodified fork of lms/develop)

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   lms/public/frontend/index.html
        modified:   yarn.lock

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        frontend/yarn.lock

I thought the yarn.lock files should be checked into the repo?
Also, shouldn't the lms/public/frontend/index.html be ignored?

To Reproduce
Steps to reproduce the behavior:

  1. set lms git branch to develop
  2. bench update --reset
  3. cd apps/lms
  4. git status

Using git version 2.39.2 if that matters...

Expected behavior
There should be no modified or new files after the 'bench update' as seen by git.

Thanks for any insight. Cheers!

@dlaufen dlaufen added the bug Something isn't working label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant