Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs "disappear" when we switch to Discussions tab in manage batch page #899

Open
NagariaHussain opened this issue Jun 27, 2024 · 3 comments
Open

Tabs "disappear" when we switch to Discussions tab in manage batch page #899

NagariaHussain opened this issue Jun 27, 2024 · 3 comments
Assignees
@pateljannat
Labels
bug Something isn't working

Comments

@NagariaHussain
Copy link
Member

CleanShot.2024-06-27.at.13.57.30.mp4
@NagariaHussain NagariaHussain added the bug Something isn't working label Jun 27, 2024
@NagariaHussain
Copy link
Member Author

Turns out the issue is with the scroll, tabs get scrolled out of view instead of inner part getting scrolled.

@NagariaHussain NagariaHussain changed the title Tabs disappear when we switch to Discussions tab in manage batch page Tabs "disappear" when we switch to Discussions tab in manage batch page Jun 27, 2024
@pateljannat
Copy link
Collaborator

@NagariaHussain the scroll was added on purpose because when the batch has a long discussion thread the scroll was meant to get the user to the latest message of the thread.

I'll add a condition to prevent the scroll when there are no discussion messages.

@NagariaHussain
Copy link
Member Author

I understand that. But the tabs should not be part of the scroll view IMO. They are part of the "navigation".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pateljannat pateljannat

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pateljannat @NagariaHussain