Poor Design

[NVentimiglia]

Here are some problems I ran into trying to do a simple address validation.

• None of the Shippo properties are typed. This makes basic data entry impossible without referencing the documentation and is very error prone.
• Examples sometimes use a factory method and sometimes use an object initializer. The first shipment example uses an object intializer while the validation uses a factory method. which one is correct ?
• Address validation method takes a hashtable argument. Why am I responsible for converting your objects into hashtables ? Why not use an address object ?

[NVentimiglia]

#11

[HakanL]

I made a fork where I re-wrote this to use .NET Standard 1.3 and started to clean up the interface as well (not using Hashtables, etc). Check it out: https://github.com/HakanL/shippo-csharp-client

Also uploaded to NuGet: https://www.nuget.org/packages/Haukcode.GoShippo

I'm in the process of testing it out so I'm sure there are a few issues.