Sobek runtime shouldn't be accessed while parsing options in async APIs

[ankur22]

What

We must not work with the goja runtime when the browser module is running a promisified API call off the event loop i.e. on a new goroutine. All promisified APIs in the browser run in a new goroutine. A concrete example of such a case is with page.goto where it is parsing the goja values in the new goroutine, which should be moved to the mapping layer.

This issue only deals with the refactoring of the option and argument parsing, #1182 deals with the inner goja usage.

Why

The goja runtime is not thread safe and should only be accessed when running on the event loop. If this is not adhered to, it can cause panics during runtime.

How

The following is the list of all async/promisified APIs, check each one and ensure that the goja runtime is only accessed in the event loop thread and not in the new go routine.

Tasks

Beta Give feedback

1. Refactor locator.click parse #1164
   +0
2. Refactor goja runtime value parsing out of elementHandle.click #1169
   2 of 2
   bug +1
   
3. Refactor goja runtime value parsing out of frame.click promise #1172
   2 of 2
   bug +1
   
4. Refactor goja runtime value parsing out of page.click promise #1174
   2 of 2
   bug +1
   
5. Refactor goja runtime value parsing out of frame and page goto #1176
   2 of 2
   bug +1
   
6. Refactor goja runtime value parsing out of page.goto #1177
   1 of 1
   bug +1
   
7. Refactor goja runtime value parsing out of frame.waitForFunction promise #1180
   2 of 2
   bug +1
   
8. Refactor goja runtime value parsing out of page.waitForFunction promise #1181
   2 of 2
   bug +1
   
9. Refactor goja runtime value parsing out of frame.waitForNavigation promise #1184
   2 of 2
   bug +1
   
10. Refactor goja runtime value parsing out of page.waitForNavigation promise #1185
    2 of 2
    bug +1
    
11. Refactor goja runtime value parsing out of browserContext.waitForEvent promise #1187
    2 of 2
    bug +1
    
12. Refactor goja runtime value parsing out of page.goBack promise #1178
    0 of 2
    bug +1
13. Fix browserContext.setExtraHTTPHeaders (unimplemented method)
14. Add fixes to release notes: Add goja refactors in browser module to release notes k6#3578

Note

[inancgumus]

Nice initiative! Thanks. Related: #1064.

[inancgumus]

Should we close this one? @ankur22