Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

Set up CI test matrix to test three-elements against different versions of Three.js #38

Open
hmans opened this issue Jan 27, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@hmans
Copy link
Owner

hmans commented Jan 27, 2021

We should test against a bunch of recent Three.js releases to be able to quickly spot regressions if there are any.

  • See ci.yml
  • See Using a Build Matrix
  • Now we just need to figure out how to inject the different three.js versions into our package.json. :S
@hmans hmans added the enhancement New feature or request label Jan 27, 2021
@CodyJasonBennett
Copy link
Contributor

Is there a cut-off point for three releases we should test against? I'm worried about slowed tests.

@hmans hmans added the help wanted Extra attention is needed label Jan 27, 2021
@hmans
Copy link
Owner Author

hmans commented Jan 27, 2021

Is there a cut-off point for three releases we should test against? I'm worried about slowed tests.

I would set it up to test against maybe the last 3 major releases. Also, consider that this is only in GitHub Actions; locally, tests will only run against whatever we have configured in devDependencies (which will typically be the newest release.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants