Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all-countries.js [main & legacy branches] #453

Open
AlexeyZelenko opened this issue Apr 2, 2024 · 5 comments
Open

Update all-countries.js [main & legacy branches] #453

AlexeyZelenko opened this issue Apr 2, 2024 · 5 comments

Comments

@AlexeyZelenko
Copy link

Hi,
Will we have an updated list in vue-tel-input@legacy?
+61 461 294 482
mobile number is not being accepted. It says "Phone number is wrong for selected country."

Displayed here correctly:
https://vue-tel-input.iamstevendao.com/

Thank you.

@iamstevendao
Copy link
Owner

iamstevendao commented Apr 2, 2024

@AlexeyZelenko can you send the props you are using?

@AlexeyZelenko
Copy link
Author

<tel-field id="contact-phone"
ref="telField"
v-model="phone"
:default-country="defaultCountry"
@country-changed="phoneCountryChange"
:auto-default-country="true"
:input-options="phoneInputOptions"
@input="onInput"
@Validate="validatePhone"
class="checkout-contact--input-phone" />

@AlexeyZelenko
Copy link
Author

"vue-tel-input": "^5.15.0"

@AlexeyZelenko
Copy link
Author

AlexeyZelenko commented Apr 2, 2024

@iamstevendao
Your dependencies are outdated, could you update it?
"libphonenumber-js": "^1.10.12"

Current version
1.10.59

Applies to Vue3 now
"libphonenumber-js": "^1.10.51"

Please update the version vue-tel-input@legacy

@AndrewFeeney
Copy link

AndrewFeeney commented Apr 11, 2024

I am also experiencing this issue with vue-tel-input 5.15.0 and an Australian phone number with the pattern +61 461 *** ***. I've tested by building from source with the latest version of libphonenumber-js and it works. Because libphonenumber-js is being bundled within the dist module, whatever version is current when the package is built for release is the one that gets shipped, even though the dependency constraint ^1.10.12 would match the latest version. Unless I'm mistaken you'll need to run npm update libphonenumber-js and rebuild and release a patch release this every time that package is released to include the updated version of the dependency. Alternatively, libphonenumber-js could be made a peer dependency, and users of the package can rebuild their own projects pulling in the latest libphonenumber-js as needed when it is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants