Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elvis github integration fails when renaming files #291

Closed
elbrujohalcon opened this issue Nov 4, 2015 · 1 comment
Closed

Elvis github integration fails when renaming files #291

elbrujohalcon opened this issue Nov 4, 2015 · 1 comment
Labels

Comments

@elbrujohalcon
Copy link
Member

If, in a PR, a file is just renamed (i.e. not modified, just mv x y), it includes no patch attribute in its JSON description. Therefore this fails with a function_clause error:

-module(elvis_webhook).

…

file_info(Cred, Repo,
          #{<<"filename">> := Filename,
            <<"raw_url">> := RawUrl,
            <<"patch">> := Patch}) ->
@harenson
Copy link
Member

harenson commented Jan 7, 2016

This is not an elvis issue but a gadget issue and it is already fixed.

Also elvis_webhook:file_info/3 return the information for every file in the GithubFiles parameter passed to elvis_webhook:handle_pull_request/3 and everyone of those files does contain a <<"patch">> key.

@harenson harenson closed this as completed Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants