Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncorrect detecting length of unicode strings #301

Closed
platinumthinker opened this issue Nov 20, 2015 · 7 comments
Closed

Uncorrect detecting length of unicode strings #301

platinumthinker opened this issue Nov 20, 2015 · 7 comments
Labels

Comments

@platinumthinker
Copy link

@jfacorro I use elvis from git repo (hash c0453e8)
and erlang-17. This bug repeating,
I checket with headers for unicode and without (%% -- coding: utf-8 --)
Proof - git@github.com:platinumthinker/elvis_unicode_fail.git

@platinumthinker
Copy link
Author

@jfacorro ping?

@jfacorro
Copy link
Contributor

@platinumthinker Sorry, I haven't had time to look into this. I'm not sure when I will be able to check this out, hopefully next week.

@platinumthinker
Copy link
Author

ok)

@platinumthinker
Copy link
Author

@jfacorro ping?

@jfacorro jfacorro added the bug label Dec 4, 2015
@jfacorro
Copy link
Contributor

jfacorro commented Dec 4, 2015

@platinumthinker I just ran elvis's version from master on the repository where this problem is exemplified and didn't get a warning concerning the line with a lot of unicode characters.

screen shot 2015-12-04 at 10 28 51 am

I tried with OTP 18.1 and OTP 17.5 and got the same result both times. This commit changed the detection of line length to take into account the unicode characters and not the amount of bytes, which fixes the bug you are reporting. I see you seem to be using a commit that includes that fix, so I'm not sure what the problem is in your case.

@jfacorro jfacorro closed this as completed Dec 4, 2015
@jfacorro jfacorro reopened this Dec 4, 2015
@jfacorro
Copy link
Contributor

jfacorro commented Dec 4, 2015

@platinumthinker I reopened the issue so you can try again running elvis and we can try to figure out your problem.

@platinumthinker
Copy link
Author

Sorry.. I update elvis but forgot update dependency..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants