-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncorrect detecting length of unicode strings #301
Comments
@jfacorro ping? |
@platinumthinker Sorry, I haven't had time to look into this. I'm not sure when I will be able to check this out, hopefully next week. |
ok) |
@jfacorro ping? |
@platinumthinker I just ran I tried with OTP 18.1 and OTP 17.5 and got the same result both times. This commit changed the detection of line length to take into account the unicode characters and not the amount of bytes, which fixes the bug you are reporting. I see you seem to be using a commit that includes that fix, so I'm not sure what the problem is in your case. |
@platinumthinker I reopened the issue so you can try again running elvis and we can try to figure out your problem. |
Sorry.. I update elvis but forgot update dependency.. |
@jfacorro I use elvis from git repo (hash c0453e8)![git@github.com:platinumthinker/elvis_unicode_fail.git]()
and erlang-17. This bug repeating,
I checket with headers for unicode and without (%% -- coding: utf-8 --)
Proof -
The text was updated successfully, but these errors were encountered: