Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #418

Closed
Euen opened this issue Nov 16, 2016 · 2 comments
Closed

Fix tests #418

Euen opened this issue Nov 16, 2016 · 2 comments
Assignees
Milestone

Comments

@Euen
Copy link
Member

Euen commented Nov 16, 2016

No description provided.

@DBoroujerdi
Copy link

Failure is partly down to the dialyzer test. This is due to the code in test/example/pass_no_useless_seqbind.erl not compiling.

However, this is intentional as its purpose is for asserting that elvis does not warn about the use of the seqbind parse transform. As the binding are not really required for the purposes of this test a quick fix would be to remove the seqbind bindings to keep the dialyzer test happy.

And so pass_no_useless_seqbind.erl becomes,

-module(pass_no_useless_seqbind).

-compile({parse_transformer, seqbind}).

-export([demo/0]).

demo() ->
    X1 = 10,
    X2 = X1 + 1,
    X2.

I've made this change in my repo and it seems to work, however, there does seem to be some remaining failures to do with lager not starting but there's a PR waiting that removes lager completely.

@ferigis
Copy link
Member

ferigis commented Feb 9, 2017

Tests are already working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants