Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create elvis.config.sample file #438

Closed
ferigis opened this issue Mar 1, 2017 · 5 comments
Closed

Create elvis.config.sample file #438

ferigis opened this issue Mar 1, 2017 · 5 comments
Assignees
Labels
documentation Documentation
Milestone

Comments

@ferigis
Copy link
Member

ferigis commented Mar 1, 2017

with all the available fields. Related to [#437]

@igaray igaray self-assigned this Jan 2, 2019
@igaray igaray added this to the 0.4.0 milestone Jan 2, 2019
@jfacorro jfacorro added the documentation Documentation label Nov 25, 2019
@paulo-ferraz-oliveira
Copy link
Collaborator

Is the Rules wiki enough for this? Or should we consider a different location for this file? I don't mind tackling this issue. I might even learn a few new things about elvis.

@elbrujohalcon
Copy link
Member

elbrujohalcon commented Sep 7, 2020

We should add something like this to that wiki to solve the issue…

[
 {
   elvis,
   [
    {config,
     [#{dirs => ["src"],
        filter => "*.erl",
        ruleset => erl_files,
        rules => [
            % your exceptional rules
        ]
      },
      #{dirs => ["test"],
        filter => "*.erl",
        ruleset => erl_files,
        rules => [
            % your exceptional rules
        ]
      },
      #{dirs => ["."],
        filter => "elvis.config",
        ruleset => elvis_config,
        rules => [
            % your exceptional rules
        ]
      },
      …
     ]
    }
   ]
 }
].

The idea being that someone can just add that elvis.config to their project and then tune it.

@elbrujohalcon
Copy link
Member

with all possible entries (i.e. one for rebar.confg, one for Makefile, I guess…)

@paulo-ferraz-oliveira paulo-ferraz-oliveira self-assigned this Sep 7, 2020
@paulo-ferraz-oliveira
Copy link
Collaborator

I added the example elvis.config section here: https://github.com/inaka/elvis_core/wiki/Rules#example-elvisconfig. I'm going to review the rules now.

@elbrujohalcon
Copy link
Member

Excellent!!

@paulo-ferraz-oliveira paulo-ferraz-oliveira removed their assignment Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation
Projects
None yet
Development

No branches or pull requests

5 participants