Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elvis.config not honored for the elvis bot #439

Closed
Licenser opened this issue Mar 4, 2017 · 4 comments
Closed

elvis.config not honored for the elvis bot #439

Licenser opened this issue Mar 4, 2017 · 4 comments
Assignees
Labels

Comments

@Licenser
Copy link
Contributor

Licenser commented Mar 4, 2017

I'm a bit baffled on this,
I recently had a pull request on a repo using elvis to check for code style (love it!) and the bot was insistant that the code violates the style guide.

dalmatinerdb/dalmatinerdb#115

is the pull request in question.

I did run elvis locally with the rebar3_lint plugin and it did pass so I have the feeling that the bot for some reason didn't recognize the settings in the elvis.config

@elbrujohalcon
Copy link
Member

elbrujohalcon commented Mar 6, 2017

According to elvis server logs:

[Github API] Error: Uri: /repos/dalmatinerdb/dalmatinerdb/contents/elvis.config?ref=read-opts

Error:
  { 404
  , [ {<<"Server">>,<<"GitHub.com">>}
    , {<<"Date">>,<<"Sat, 04 Mar 2017 13:30:19 GMT">>}
    , {<<"Content-Type">>,<<"application/json; charset=utf-8">>}
    , {<<"Content-Length">>,<<"121">>}
    , {<<"Status">>,<<"404 Not Found">>}
    , {<<"X-RateLimit-Limit">>,<<"5000">>}
    , {<<"X-RateLimit-Remaining">>,<<"4998">>}
    , {<<"X-RateLimit-Reset">>,<<"1488637819">>}
    , {<<"X-GitHub-Media-Type">>,<<"github.v3; format=json">>}
    , {<<"Access-Control-Expose-Headers">>,<<"ETag, Link, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval">>}
    , {<<"Access-Control-Allow-Origin">>,<<"*">>}
    , {<<"Content-Security-Policy">>,<<"default-src 'none'">>}
    , {<<"Strict-Transport-Security">>,<<"max-age=31536000; includeSubdomains; preload">>}
    , {<<"X-Content-Type-Options">>,<<"nosniff">>}
    , {<<"X-Frame-Options">>,<<"deny">>}
    , {<<"X-XSS-Protection">>,<<"1; mode=block">>}
    , {<<"X-GitHub-Request-Id">>,<<"9496:04A9:7671E0:97B94E:58BAC16B">>}
    ]
  , <<"{\"message\":\"No commit found for the ref read-opts\",\"documentation_url\":\"https://developer.github.com/v3/repos/contents/\"}">>
  }

@elbrujohalcon
Copy link
Member

I see what's going on!! It's looking for elvis.config in the right branch but in the wrong repo!! 😊

@Licenser
Copy link
Contributor Author

Licenser commented Mar 6, 2017

Ohhhh sneaky! :D

@elbrujohalcon
Copy link
Member

Elvis bot is dead :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants