Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --verbose flag, obey rule of silence of it's not passed #447

Closed
srenatus opened this issue Jun 4, 2017 · 3 comments
Closed

Add --verbose flag, obey rule of silence of it's not passed #447

srenatus opened this issue Jun 4, 2017 · 3 comments

Comments

@srenatus
Copy link
Contributor

srenatus commented Jun 4, 2017

Hey there.

I'd like to work on a small PR that makeselvis rock output nothing (but exit 0) if there's no violation found, and output the rule violations only if there are any.

Executing elvis --verbose rock would then make elvis behave like it does today

I expect that this proposal needs some discussion, and I could be convinced that a --quiet flag would be preferable (to not change the default). However, my favourite behaviour would be no-problem-no-output.

Any thoughts?

@elbrujohalcon
Copy link
Member

I like your original idea, as long as, if there are warnings they're printed out as they're today.

@srenatus
Copy link
Contributor Author

srenatus commented Jun 6, 2017

😃 Yay!

I've noticed that there already is a no_output flag in elvis_core, but it's not set by elvis. However, it's suppressing all output, which isn't what we'd want here.

@srenatus
Copy link
Contributor Author

srenatus commented Jun 8, 2017

I'd assumed that #448's "Fixes..." comment would close this automatically... anyhow, thanks for merging those PRs, I'm looking forward to the next elvis release 😉

@srenatus srenatus closed this as completed Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants