Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make corrections for detected problems #478

Closed
vladdu opened this issue Mar 3, 2018 · 4 comments
Closed

Make corrections for detected problems #478

vladdu opened this issue Mar 3, 2018 · 4 comments

Comments

@vladdu
Copy link

vladdu commented Mar 3, 2018

I've got a question on the erlang/sourcer project about integrating the code formatter with elvis. erlang/sourcer#14

This falls in a gray zone, as I don't think the implementation would use any sourcer code, so it could just as well be part of elvis.

What is your opinion on this?

cc: @deadtrickster

@deadtrickster
Copy link

Yep, that's one of the options, perhaps even preferred one.

@elbrujohalcon
Copy link
Member

Hi, @vladdu @deadtrickster.

Getting elvis to auto-fix (or to recommend fixes) for the warnings it produces has been in our minds for quite a while but we never got around to actually implement it. Partially because sometimes elvis checks the source code directly, but others it checks the AST and many times a combination of both, so it easily loose track of the exact place in the source file where to apply the patch.
That's not to say it can't be done, but unless someone has a lot of interest and spare time to invest in this, I don't see this happening in the short term.

@jfacorro
Copy link
Contributor

I don't think it should be elvis the one who takes care of formatting code, ideally a different formatting tool should be used in which elvis rules can be provided.

Implementing this in elvis would make the code base really complex and therefore IMO out of scope for this tool.

@elbrujohalcon
Copy link
Member

I agree with @jfacorro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants